Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves issue #951 by adding support for the Red Hat OpenShift on AWS (rosa) cli tool #966

Closed
wants to merge 1 commit into from
Closed

Resolves issue #951 by adding support for the Red Hat OpenShift on AWS (rosa) cli tool #966

wants to merge 1 commit into from

Conversation

mkimberley
Copy link
Contributor

@mkimberley mkimberley commented Aug 3, 2023 •
edited
Loading

  • Adds a new tool "rosa" which is the cli for Red OpenShift on AWS

Description

  • Modified tools.go, README.md and get_test.go to add the new tool

Motivation and Context

How Has This Been Tested?

  • make e2e
  • using test-tool.sh

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME

./test-tool.sh rosa
+ ./arkade get rosa --arch arm64 --os darwin --quiet
+ file /Users/matt/.arkade/bin/rosa
/Users/matt/.arkade/bin/rosa: Mach-O 64-bit executable x86_64
+ rm /Users/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os darwin --quiet
+ file /Users/matt/.arkade/bin/rosa
/Users/matt/.arkade/bin/rosa: Mach-O 64-bit executable x86_64
+ rm /Users/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os linux --quiet
+ file /Users/matt/.arkade/bin/rosa
/Users/matt/.arkade/bin/rosa: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=zc0zaJD6A5pZUpnZvzxM/EuR4UKJoDl1spt81-lsG/kpGc4hRgdWEXBbKPnqUc/aLqW7g4ULuz5Gqw-PDm0, not stripped
+ rm /Users/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch aarch64 --os linux --quiet
+ file /Users/matt/.arkade/bin/rosa
/Users/matt/.arkade/bin/rosa: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=zc0zaJD6A5pZUpnZvzxM/EuR4UKJoDl1spt81-lsG/kpGc4hRgdWEXBbKPnqUc/aLqW7g4ULuz5Gqw-PDm0, not stripped
+ rm /Users/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os mingw --quiet
+ file /Users/matt/.arkade/bin/rosa.exe
/Users/matt/.arkade/bin/rosa.exe: PE32+ executable (console) x86-64 (stripped to external PDB), for MS Windows
+ rm /Users/matt/.arkade/bin/rosa.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

@mkimberley
Resolves issue alexellis#951 by adding support for the Red Hat OpenShift
60ebdd4 
on AWS (rosa) cli tool

Signed-off-by: Matt Kimberley <[email protected]>
Jasstkn
Jasstkn reviewed Aug 31, 2023
View reviewed changes
README.md
@@ -836,6 +836,7 @@ There are 56 apps that you can install on your cluster.
| [promtool](https://github.com/prometheus/prometheus) | Prometheus rule tester and debugging utility |
| [rekor-cli](https://github.com/sigstore/rekor) | Secure Supply Chain - Transparency Log |
| [replicated](https://github.com/replicatedhq/replicated) | CLI for interacting with the Replicated Vendor API |
| [rosa](https://github.com/openshift/rosa) | Red Hat OpenShift on AWS (ROSA) command line tool |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Could you regenerate the table? There must be one more line with the changed numbers of tools.

pkg/get/get_test.go

tests := []test{
{
os: "linux",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are missing a few tests here for different archs. e.g. https://github.com/alexellis/arkade/blob/master/pkg/get/get_test.go#L6467

pkg/get/tools.go
Comment on lines +3691 to +3697
{{- if eq .Arch "aarch64" -}}
{{$arch = "-arm64"}}
{{- else if eq .Arch "arm64" -}}
{{ $arch = "-arm64" }}
{{- else if eq .Arch "x86_64" -}}
{{ $arch = "" }}
{{- end -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch is not being used in the template, why do we need it?

@alexellis
Copy link
Owner

@mkimberley when do you expect to be able to check out Maria's comments? Let me know and I'll try to come back then to check again.

@mkimberley
Copy link
Contributor Author

@mkimberley when do you expect to be able to check out Maria's comments? Let me know and I'll try to come back then to check again.

Hi Alex, appreciate the feedback from Maria. I should be able to get this done in the next two weeks, just working on a project for work atm

@rgee0 rgee0 mentioned this pull request Oct 26, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasstkn Jasstkn Jasstkn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkimberley @alexellis @Jasstkn